Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and much more extensive testing #16

Merged
merged 7 commits into from
Dec 28, 2013
Merged

Bugfixes and much more extensive testing #16

merged 7 commits into from
Dec 28, 2013

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 27, 2013

No description provided.

w=WeakRef(w)
gc(); gc(); sleep(.1); gc()
@assert w.value.handle == C_NULL
# FIXME: I get a segfault now if I uncomment the next lines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open an issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get a segfault here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not getting it either. Weird. It was quite reliable (3x in a row), but it had never happened before, either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange. are you sure you weren't getting the segfault further on (in signal_emit), when you were feeding Gtk uninitialized memory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember whether I was running the whole script or just the top part. But that explanation seems so plausible that I certainly can't deny it; perhaps just the randomness of what memory got fed.

Didn't realize I had to construct the event itself, that's good to know (and makes sense).

@vtjnash
Copy link
Contributor

vtjnash commented Dec 27, 2013

looks good to me. i'll leave it open in case you wanted to add anything else before you merge

@timholy
Copy link
Member Author

timholy commented Dec 27, 2013

I'm done for the day, so feel free to merge or just let sit until tomorrow or later. There are a few more exported items that should be tested.

@vtjnash vtjnash merged commit 3ae716f into JuliaGraphics:master Dec 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants