Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable uv_backend_fd integration #630

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Disable uv_backend_fd integration #630

merged 1 commit into from
Mar 3, 2022

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Mar 2, 2022

Might fix #503
Closes JuliaLang/julia#35552

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #630 (a81d57e) into master (d76faaa) will decrease coverage by 1.17%.
The diff coverage is n/a.

❗ Current head a81d57e differs from pull request most recent head 28066d6. Consider uploading reports for the commit 28066d6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   65.69%   64.52%   -1.18%     
==========================================
  Files          32       32              
  Lines        2720     2227     -493     
==========================================
- Hits         1787     1437     -350     
+ Misses        933      790     -143     
Impacted Files Coverage Δ
src/GLib/signals.jl 74.64% <ø> (-1.18%) ⬇️
src/GLib/glist.jl 77.93% <0.00%> (-6.99%) ⬇️
src/layout.jl 71.42% <0.00%> (-6.00%) ⬇️
src/GLib/MutableTypes.jl 59.09% <0.00%> (-4.91%) ⬇️
src/gdk.jl 50.00% <0.00%> (-4.84%) ⬇️
src/selectors.jl 20.65% <0.00%> (-4.58%) ⬇️
src/GLib/GLib.jl 73.68% <0.00%> (-2.51%) ⬇️
src/toolbar.jl 87.50% <0.00%> (-2.50%) ⬇️
src/container.jl 64.28% <0.00%> (-2.39%) ⬇️
src/buttons.jl 64.78% <0.00%> (-2.28%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76faaa...28066d6. Read the comment docs.

@jwahlstrand
Copy link
Contributor

I can confirm that this works on Mac, Linux, and Windows. I see some sporadic lag in the REPL but it's not really reproducible or particularly bothersome. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major slowdown on Linux due to Gtk.jl + @threads for Major slowdowns with Gtk + Threads
3 participants