Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests and precompile #14

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Conversation

bjarthur
Copy link
Member

@bjarthur bjarthur commented Apr 7, 2017

exchanged FactCheck for Base.Test to remove a dependency.

and turned on precompilation. it's a small package, but is there any reason not to?

@codecov-io
Copy link

codecov-io commented Apr 7, 2017

Codecov Report

Merging #14 into master will decrease coverage by 2.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage    33.8%   30.98%   -2.82%     
==========================================
  Files           6        6              
  Lines          71       71              
==========================================
- Hits           24       22       -2     
- Misses         47       49       +2
Impacted Files Coverage Δ
src/Measures.jl 0% <ø> (ø) ⬆️
src/operations.jl 50% <0%> (-7.15%) ⬇️
src/length.jl 64.7% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e3a58...ba37e02. Read the comment docs.

@tlnagy
Copy link
Member

tlnagy commented Apr 11, 2017

Any idea why codecov doesn't like this PR?

@bjarthur
Copy link
Member Author

well it's either that coverage is already a miserable ~30% or that for some reason it decreased by 2%. either way, i think fixing that is a separate issue. might not be worth doing at all if long-term we're considering switching to unitful.jl.

@shashi shashi merged commit 182eb14 into JuliaGraphics:master Apr 12, 2017
@shashi
Copy link
Collaborator

shashi commented Apr 12, 2017

Thanks @bjarthur!

@tbenst tbenst mentioned this pull request May 13, 2021
@bjarthur bjarthur deleted the bja/tests branch October 28, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants