Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Grisu on Julia 1.6 #25

Merged
merged 2 commits into from
Sep 22, 2020
Merged

fix for Grisu on Julia 1.6 #25

merged 2 commits into from
Sep 22, 2020

Conversation

KristofferC
Copy link
Contributor

This needs JuliaRegistries/General#21688 to go through first.

Fixes #24

@KristofferC KristofferC mentioned this pull request Sep 21, 2020
Closed
aviatesk
aviatesk reviewed Sep 21, 2020
View reviewed changes
src/Showoff.jl Outdated Show resolved Hide resolved
@aviatesk
Update src/Showoff.jl
bce09c0 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@KristofferC KristofferC reopened this Sep 22, 2020
@KristofferC
Copy link
Contributor Author

Should be good to go

@daschw daschw mentioned this pull request Sep 22, 2020
Closed
@timholy timholy merged commit fa972ff into JuliaGraphics:master Sep 22, 2020
@timholy
Copy link
Member

timholy commented Sep 22, 2020

Thanks!

@timholy timholy mentioned this pull request Sep 23, 2020
Merged
@KristofferC KristofferC deleted the kc/Grisu branch September 23, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sections using Base.Grisu need to be rewritten
3 participants
@KristofferC @timholy @aviatesk