added short paragraph in docs on the dangers of deleting vertices

[henrik-wolf]

I recently found the solution to a bug in my code related to the persistence of vertex indices when deleting earlier vertices in the graph. Since this behaviour of "renaming" later vertices to fill the spots of deleted ones is (at least from my point of view) fairly unexpected, I decided to contribute a little paragraph in the documentation.
Let me know what you think about it.
(also... am I requesting the right pull target? Do I need to build something for this to work?)

[codecov]

Codecov Report

Merging #179 (88de075) into master (1783617) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   97.47%   97.23%   -0.25%     
==========================================
  Files         109      114       +5     
  Lines        6349     6584     +235     
==========================================
+ Hits         6189     6402     +213     
- Misses        160      182      +22     

[gdalle]

Thanks @SuperGrobi for the suggestion, indeed it is a very frequent pain point so mentioning it in the docs will help lots of people

[henrik-wolf]

Thank you very much for the review! I find the whole github-interface somewhat unintuitive, so just to be sure that I am not missing anything substantial: do I need to do something here to accept the requested changes? Or has that to be done by another reviewer with elevated access?

[gdalle]

do I need to do something here to accept the requested changes? Or has that to be done by another reviewer with elevated access?

In this instance I took care of it, but you could also have accepted the modifications because they happen on your branch, not on the main repo. The only time you need someone with merge access is to incorporate your changes into the official code

Outdated