Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos #182

Merged
merged 1 commit into from
Oct 17, 2022
Merged

fixed typos #182

merged 1 commit into from
Oct 17, 2022

Conversation

aurorarossi
Copy link
Member

I fixed the following typos:
ga in g
image
and the repetition

e  edges(g) or e  edges(g)

in

e in edges(g) or e  edges(g)

image

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #182 (59d00e7) into master (1783617) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         109      109           
  Lines        6349     6349           
=======================================
  Hits         6189     6189           
  Misses        160      160           

Copy link
Contributor

@simonschoelly simonschoelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes look good.

On a side note, it is kind of incorrect, that edges calls has_edge - this is neither the case for AbstractGraph nor for Simple[Di]Graph.

It would possibly be worth to think about having an implementation edges(g::AbstractGraph) that relies on calls to has_edge by default while other types of graphs are free to implement their own more efficient edges function.
Also, this approach would not work for multigraphs though.

@simonschoelly simonschoelly merged commit db43758 into JuliaGraphs:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants