-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test outputs #185
Change test outputs #185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 109 109
Lines 6349 6349
=======================================
Hits 6189 6189
Misses 160 160 |
@gdalle I would have appreciated if that would have still been left open for discussion. |
Ah, I realized that I only communicated on slack, so there was no trace of me reviewing |
@simonschoelly issue #181 is still open so we can discuss there if you have other suggestion. |
My bad @simonschoelly, I thought it was sufficiently minor to approve directly and I didn't think of any downsides to having more detailed test outputs. I didn't see the discussion on Slack though, I'll go there to check it out. Mea culpa! |
@gdalle No sorry, this is totally my fault. I had completely forgotten that I never started doing the code review here on github and was still in the progress of trying to figure out in what way the test outputs were changing. Of course it should not be necessary to double check on slack. |
Alright then! I haven't been very Slacking recently but it should get better soon :) |
As I wrote in issue #181, the test outputs were hiding the summary table.
With this pull request I hid the long outputs and I set
verbose = true
to have more readable information in the summary table.