Algorithm for finding the longest path of a DAG

[matheusdiogenesandrade]

DAG longest path algorithm.

[matheusdiogenesandrade]

Could someone help me with this test case?

Code formatting (JuliaFormatter.jl): Test Failed at /home/runner/work/Graphs.jl/Graphs.jl/test/runtests.jl:24
  Expression: format(Graphs; verbose = false, overwrite = false, ignore = ["vf2.jl"])

Even locally I am not able to pass it.

[aurorarossi]

I had the same problem (I solved it in a PR that is still in progress).
It should work by removing the parentheses in the runtest.jl file here: ignore = ["vf2.jl"] --> ignore = "vf2.jl".

[simonschoelly]

I had the same problem (I solved it in a PR that is still in progress). It should work by removing the parentheses in the runtest.jl file here: ignore = ["vf2.jl"] --> ignore = "vf2.jl".

If you have time, maybe you can create a separate PR just for that change, so that we could merge it quickly?

[matheusdiogenesandrade]

@aurorarossi Thanks, just made this, let's see now. @simonschoelly, I pushed the changes, what do you mean by making another PR? I am sorry, but this is my first open-source contribution, thus I am not used to some usual tasks.

[aurorarossi]

@aurorarossi Thanks, just made this, let's see now. @simonschoelly, I pushed the changes, what do you mean by making another PR? I am sorry, but this is my first open-source contribution, thus I am not used to some usual tasks.

I think that @simonschoelly was referring to me. Do not worry, I will take care of it :).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (da6f801) to head (989b819).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   97.26%   97.29%   +0.03%     
==========================================
  Files         115      117       +2     
  Lines        6795     6814      +19     
==========================================
+ Hits         6609     6630      +21     
+ Misses        186      184       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matheusdiogenesandrade]

@aurorarossi thanks. Folks, concerning this last checking (https://github.com/JuliaGraphs/Graphs.jl/pull/209/checks?check_run_id=10444689306), can someone help me to understand why it is failing?

Thanks.

[aurorarossi]

It means that some lines are not covered by a test.

[matheusdiogenesandrade]

@aurorarossi Thank you! So I think that providing unitary tests (as I did https://github.com/JuliaGraphs/Graphs.jl/pull/209/files#diff-9c1223f541fc1697a6f988c8c086087d93a6467d5f7da2a2d9b2cd612c92184f) is not enough. What sort of additional tests should I provide?

Regards.

[matheusdiogenesandrade]

@aurorarossi never mind, I forgot to insert my test file in the runtests.jl.

[matheusdiogenesandrade]

Sorry, I am quite lost on how to solve these conflicts. Does anyone have any suggestion?

Thnx, and regards.

[gdalle]

@matheusdiogenesandrade thank you for the contribution!

I brought it up to speed with the latest changes and I simplified the syntax a bit. The doctest is still unreliable (it might fail or succeed), but it would be interesting for you to try and figure out why on your own :) If you don't find the reason, I can help.

As a side note, you don't need to declare the type of every object you create, in most cases Julia will infer it for you!

[matheusdiogenesandrade]

@matheusdiogenesandrade thank you for the contribution!

I brought it up to speed with the latest changes and I simplified the syntax a bit. The doctest is still unreliable (it might fail or succeed), but it would be interesting for you to try and figure out why on your own :) If you don't find the reason, I can help.

As a side note, you don't need to declare the type of every object you create, in most cases Julia will infer it for you!

Thanks. I think I solved the issue.

[gdalle]

You did but you overwrote my previous changes to the longest paths source file in the process. Can you revert your latest commit and just change the necessary seed?

More tests would also be welcome with a different topological order

[matheusdiogenesandrade]

You did but you overwrote my previous changes to the longest paths source file in the process. Can you revert your latest commit and just change the necessary seed?

More tests would also be welcome with a different topological order

Sorry, it was an accident, but now I think it is ok. Are the erros with the nightly julia version normal?

Regards.

[matheusdiogenesandrade]

Thank very much everyone!