Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #143 #229

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix #143 #229

merged 1 commit into from
Feb 17, 2023

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Feb 17, 2023

Add a recommendation to the docs saying that the heuristic for A* should return values that have the same type as the edge weights

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #229 (4627f19) into master (3271ee6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files         114      114           
  Lines        6585     6585           
=======================================
  Hits         6403     6403           
  Misses        182      182           

@etiennedeg
Copy link
Member

Keep the issue open though, I think it should be possible to find a solution to this

@gdalle gdalle merged commit 53cb581 into master Feb 17, 2023
@gdalle gdalle deleted the fix_astar_heuristic_type branch May 31, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants