Test centrality with generic graph #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 97.19% 97.28% +0.09%
==========================================
Files 114 114
Lines 6656 6657 +1
==========================================
+ Hits 6469 6476 +7
+ Misses 187 181 -6 |
|
Partial solution for #224 |
simonschoelly
force-pushed
the
test-centrality-with-generic-graph
branch
from
f3dce5d
to
c8bcea3
Compare
12 tasks
simonschoelly
force-pushed
the
test-centrality-with-generic-graph
branch
from
c8bcea3
to
624d9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the centrality algorithms so that they test with GenericGraph instead of SimpleGraph.
Some tests did fail, because we passed the output of
vertices(g)todegree- but previously that function would not only accept anAbstractVectorand not a generic collection of vertices, so I changedindegree,outdegreeanddegree, so that they can take an arbitrary collection of vertices. Maybe in the future, we could also just demand, thatvertices(g)returns anAbstractVector.Furthermore there was an issue with
betweenness_centralitywhere we tried to index intovertices(g)- this also would have been a non-issue, ifvertices(g)was anAbstractVector.Lastly, I had to change the input in the
samplemethod, that could also not deal with the output ofvertices(g).