Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create feature_request version of issues #289

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Jul 27, 2023

Noticed that there is no Feature request version of issues, what about adding one?

@simonschoelly
Copy link
Contributor

The reason why we have a template for bugs is, that in the past people reported bugs but forgot to add the necessary information to reproduce, I don't mind having a template for feature requests - as long as there are not a lot of unnecessary fields to will shy people away from creating such feature requests.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #289 (9485b81) into master (1cb789d) will not change coverage.
The diff coverage is n/a.

❗ Current head 9485b81 differs from pull request most recent head 8bfc8d5. Consider uploading reports for the commit 8bfc8d5 to get more accurate results

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         115      115           
  Lines        6709     6709           
=======================================
  Hits         6528     6528           
  Misses        181      181           

@Tortar
Copy link
Contributor Author

Tortar commented Jul 28, 2023

I think that just having the button is probably fine then, It's the least intimidating version :-)

I'm doing the pull mainly since in #288 I opened a bug report using it as a feature request and it was applied automatically a bug label, surely I was a bit too lazy not to search for the right thing to click but this prevents this kind of problems at least

@gdalle gdalle merged commit 9d8fa48 into JuliaGraphs:master Aug 28, 2023
@Tortar Tortar deleted the patch-2 branch August 31, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants