Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeCov token #339

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Add CodeCov token #339

merged 5 commits into from
Feb 11, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Feb 7, 2024

@gdalle
Copy link
Member Author

gdalle commented Feb 8, 2024

Do not merge: codecov is failing for server error reasons
https://github.com/JuliaGraphs/Graphs.jl/actions/runs/7826337073/job/21352010540?pr=339

@gdalle gdalle added do not merge Do not merge this PR (yet) dependencies Pull requests that update a dependency file labels Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6f8db6) 97.28% compared to head (8b2e16c) 97.28%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         115      115           
  Lines        6789     6789           
=======================================
  Hits         6605     6605           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle removed the do not merge Do not merge this PR (yet) label Feb 8, 2024
@gdalle
Copy link
Member Author

gdalle commented Feb 8, 2024

ok we're good

Copy link
Contributor

@simonschoelly simonschoelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess if we merge this, if the code coverage is indeed correctly reported on the bade.

@gdalle
Copy link
Member Author

gdalle commented Feb 11, 2024

on the bade.

what does this mean?

@gdalle gdalle merged commit 0c29f25 into master Feb 11, 2024
9 of 12 checks passed
@gdalle gdalle deleted the gd/codecov branch February 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants