fix merge_vertices #369
Merged
fix merge_vertices #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 97.28% 97.27% -0.01%
==========================================
Files 118 118
Lines 6876 6874 -2
==========================================
- Hits 6689 6687 -2
Misses 187 187 ☔ View full report in Codecov by Sentry. |
gdalle
approved these changes
May 4, 2024
|
feel free to merge it @etiennedeg, according to ColPrac the person submitting the PR should be the one to merge it after review if they have the rights |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
In the tests, there was a loop encapsulating the
merge_verticestests, but these tests were not using the test graph, hence I moved it out and refactored it a bit.