adjacency_matrix: Collect neighbors before sorting them #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The neighbors list may be an iterator that is not sortable. Make sure to collect it first to get an array back.
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 99.46% 99.48% +0.02%
==========================================
Files 106 107 +1
Lines 5556 5595 +39
==========================================
+ Hits 5526 5566 +40
+ Misses 30 29 -1 |
Keno
commented
Dec 23, 2021
| @@ -59,7 +59,7 @@ function _adjacency_matrix(g::AbstractGraph, T::DataType, neighborfn::Function, | |||
| nz -= 1 | |||
| end | |||
| end | |||
| dsts = sort(collect(neighborfn(g, j))) # TODO for most graphs it might not be necessary to sort | |||
| dsts = sort!(collect(neighborfn(g, j))) # TODO for most graphs it might not be necessary to sort | |||
There was a problem hiding this comment.
In place sort! can be algorithmically a fair bit slower than the out of place version.
There was a problem hiding this comment.
From my benchmark, it seemed to be rather equivalent and to allocate less, but you are probably more knowledgeable than me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neighbors list may be an iterator that is not sortable. Make
sure to collect it first to get an array back.