Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure package and documentation to make it more user- and developer-friendly #16

Merged
merged 6 commits into from
Sep 9, 2021

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 6, 2021

Hey there,
I would like to use MetaGraphsNext.jl for my research, so I though "why not clean it up a bit first?". Here is my attempt to make it more accessible to users and developers.

@bramtayl
Copy link
Collaborator

bramtayl commented Sep 6, 2021

Wow, this looks amazing! I'm glad you find the package useful!

docs/Project.toml Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
gdalle and others added 4 commits September 6, 2021 18:56
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
@gdalle
Copy link
Member Author

gdalle commented Sep 7, 2021

@bramtayl do you think I've gained a sufficient knowledge of the package to get github permissions?

@bramtayl
Copy link
Collaborator

bramtayl commented Sep 7, 2021

Sure, but I don't have permission to give you permissions. I think it would have to be someone else in JuliaGraphs (not sure who)

@bramtayl
Copy link
Collaborator

bramtayl commented Sep 9, 2021

Dunno if @sbromberger is around but maybe he can give you permissions

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #16 (917dc57) into master (9aeca07) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         9    +4     
  Lines          217       227   +10     
=========================================
+ Hits           217       227   +10     
Impacted Files Coverage Δ
src/MetaGraphsNext.jl 100.00% <ø> (ø)
src/persistence.jl 100.00% <ø> (ø)
src/dict_utils.jl 100.00% <100.00%> (ø)
src/lightgraphs.jl 100.00% <100.00%> (ø)
src/metagraph.jl 100.00% <100.00%> (ø)
src/metaundigraph.jl 100.00% <100.00%> (ø)
src/weights.jl 100.00% <100.00%> (ø)
src/overrides.jl 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aeca07...917dc57. Read the comment docs.

@gdalle
Copy link
Member Author

gdalle commented Sep 9, 2021

Dunno if @sbromberger is around but maybe he can give you permissions

In the meantime, maybe you can merge this?

@bramtayl bramtayl merged commit e7d9761 into JuliaGraphs:master Sep 9, 2021
@gdalle
Copy link
Member Author

gdalle commented Sep 9, 2021

Hey @bramtayl,
Thanks for the merge! Unfortunately the Documenter CI step failed. Normally my latest commit on the gdalle branch fixed it, I'll open a new PR.

@bramtayl
Copy link
Collaborator

bramtayl commented Sep 9, 2021

Ok

@gdalle gdalle mentioned this pull request Sep 9, 2021
@bramtayl
Copy link
Collaborator

@gdalle if you're still interested in helping maintain I think @jpfairbanks is in charge now

@gdalle
Copy link
Member Author

gdalle commented Oct 31, 2021

Okay, so what should I do?

@bramtayl
Copy link
Collaborator

bramtayl commented Nov 2, 2021

Hmm, not sure, maybe @jpfairbanks can give you PR access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants