-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-stable constructors #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 90.83% 93.68% +2.84%
==========================================
Files 7 7
Lines 240 269 +29
==========================================
+ Hits 218 252 +34
+ Misses 22 17 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sorry @bramtayl this is a hell of a PR to review but we're making progress! |
Thanks!
|
Thanks, clarified this in the last commit |
As long as the positional constructor exists, it will be exported because it shares the name of the struct. It's not really a problem though cause it doesn't cause ambiguities |
There is a slight subtlety about tihs: the If you want you can |
In the latest commit I turned |
@bramtayl ready for round 2 and possible approval |
This looks great to me thanks! |
MetaGraph
type parametersSymbol
as default vertex data typearrange
apply only toMetaGraphs
copy
to new constructors==
comparing all fieldslabels
function to iterate on vertex labels