Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark and remove warning for integer labels #53

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Add benchmark and remove warning for integer labels #53

merged 2 commits into from
Mar 30, 2023

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Mar 27, 2023 •
edited

@gdalle gdalle requested a review from bramtayl March 27, 2023 14:59
@gdalle gdalle mentioned this pull request Mar 30, 2023
Closed
@gdalle
Copy link
Member Author

gdalle commented Mar 30, 2023

@bramtayl I know you feel strongly about integer labels ;)

@bramtayl
Copy link
Collaborator

this looks good! what were the benchmark results?

@gdalle
Copy link
Member Author

gdalle commented Mar 30, 2023

this looks good! what were the benchmark results?

We're better on every front, as you will soon see in the docs

@gdalle gdalle merged commit c3b3205 into master Mar 30, 2023
@gdalle
Copy link
Member Author

gdalle commented Mar 30, 2023

https://juliagraphs.org/MetaGraphsNext.jl/dev/tutorial/5_benchmark/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramtayl bramtayl Awaiting requested review from bramtayl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdalle @bramtayl