Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double quotations for labels for savedot #62

Merged
merged 6 commits into from
May 30, 2023

Conversation

Paalon
Copy link
Contributor

@Paalon Paalon commented May 29, 2023

Solve #61.

@gdalle
Copy link
Member

gdalle commented May 29, 2023

Thanks! Could you add a test while you're at it, to make sure that this doesn't happen again if the codebase changes?

@gdalle gdalle linked an issue May 29, 2023 that may be closed by this pull request
@Paalon
Copy link
Contributor Author

Paalon commented May 30, 2023

Test fails at code formatting, what should I do?

@gdalle
Copy link
Member

gdalle commented May 30, 2023

Test fails at code formatting, what should I do?

In the project environment, run

using JuliaFormatter, MetaGraphsNext
format(MetaGraphsNext)

JuliaFormatter is a good package to have in your base environment

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #62 (2e0fb4d) into master (063399b) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   93.24%   93.37%   +0.13%     
==========================================
  Files           7        7              
  Lines         296      302       +6     
==========================================
+ Hits          276      282       +6     
  Misses         20       20              
Impacted Files Coverage Δ
src/MetaGraphsNext.jl 100.00% <ø> (ø)
src/persistence.jl 100.00% <100.00%> (ø)

@gdalle
Copy link
Member

gdalle commented May 30, 2023

Documentation is failing, I'm on it

@gdalle
Copy link
Member

gdalle commented May 30, 2023

This is a breaking change so I'm bumping the version number, it will feature in the next minor release but that may not be right now

@gdalle gdalle merged commit 5c98f33 into JuliaGraphs:master May 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOT format exporter can't treat strings that have spaces
2 participants