Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Family Tree tutorial to demonstrate integration into an application's existing data model #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MarkNahabedian
Copy link

This pull request adds the tutorial "Family Tree", which demonstrates how MetaGraphsNext.jl can be incorporated into an application's existing data model to provide graph capabilities.

It also modifies the "test" workflow so that it can be manually triggered.

Currently, this test

    @testset verbose = false "Code formatting (JuliaFormatter.jl)" begin
        @test format(MetaGraphsNext; verbose=false, overwrite=false)
    end

is commented out of test/runtests.jl because it was failing in a fresh clone.

Including the actual family tree data in the tutorial feels like obfuscatory clutter. It's not obvious given how the test/doc examples are structured how to include an auviliarry data file. Suggestions?

@MarkNahabedian MarkNahabedian changed the title Add Family Tree yutorial to demonstrate integration into an application's existing data model Add Family Tree tutorial to demonstrate integration into an application's existing data model Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf77b53) 93.46% compared to head (f5f116e) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files           7        7           
  Lines         306      306           
=======================================
  Hits          286      286           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member

gdalle commented Dec 21, 2023

Thank you for the contribution! I'm going on holiday now but I'll try to review it in early January :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants