try to fix tests and docs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 84.86% 86.21% +1.34%
==========================================
Files 43 43
Lines 4534 4438 -96
==========================================
- Hits 3848 3826 -22
+ Misses 686 612 -74
... and 6 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
trying to isolate the problem
It looks like the main window is being destroyed before the dialogs have been freed. Using close seems to have the same effect but lets GTK destroy everything gracefully?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests of the
cfunction-based signal connect were segfaulting. This prevents that by splitting up the tests -- apparently the interaction of different callbacks was doing this? I will look into this further when I get a chance.Also finally fixes a crash in the dialog tests that has popped up recently. I have never observed this crash outside the tests.