Do not ]dev ADI in bench/Manifest.toml
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A local path makes it impossible to instantiate the environment on someone else's computer.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 47.79% 45.50% -2.29%
==========================================
Files 10 10
Lines 362 345 -17
==========================================
- Hits 173 157 -16
+ Misses 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closed
giordano
commented
Nov 28, 2020
Comment on lines
+5
to
+7
| git-tree-sha1 = "6bb9d25e57347c9dbd4c9eca42f019179e019cc8" | ||
| uuid = "904a6c7d-4c1b-562f-9573-ab2e7e1c7946" | ||
| version = "0.5.0" | ||
| version = "0.5.2" |
There was a problem hiding this comment.
As an alternative we can add ADI#master. The important is to not have a local path in the manifest.
mileslucas
approved these changes
Nov 28, 2020
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A local path makes it impossible to instantiate the environment on someone
else's computer.