Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Polyester #134

Merged
merged 3 commits into from
Oct 12, 2021
Merged

remove Polyester #134

merged 3 commits into from
Oct 12, 2021

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Oct 8, 2021

closes #133

@Moelf
Copy link
Member Author

Moelf commented Oct 8, 2021

this breaks @batch working on enumerate() but notice:

julia> @batch for (i,a) in enumerate(1:10)
       end
ERROR: MethodError: no method matching step(::Base.Iterators.Enumerate{ArrayInterface.OptionallyStaticUnitRange{Static.StaticInt{1}, Static.StaticInt{10}}})
Closest candidates are:
  step(::StepRange) at range.jl:633
  step(::LinRange) at range.jl:637
  step(::StepRangeLen{T, Base.TwicePrecision{T}, Base.TwicePrecision{T}}) where T<:AbstractFloat at twiceprecision.jl:442
  ...
Stacktrace:
 [1] maybe_static

so I would say let it be, @threads works on them already, and also @batch still works on just LazyTree because it's just an array

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #134 (63eece6) into master (dbeca02) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

❗ Current head 63eece6 differs from pull request most recent head 75f3cef. Consider uploading reports for the commit 75f3cef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   92.32%   92.23%   -0.10%     
==========================================
  Files          11       10       -1     
  Lines        1447     1442       -5     
==========================================
- Hits         1336     1330       -6     
- Misses        111      112       +1     
Impacted Files Coverage Δ
src/UnROOT.jl 100.00% <ø> (ø)
src/iteration.jl 88.76% <50.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbeca02...75f3cef. Read the comment docs.

@Moelf Moelf merged commit d6dedd0 into master Oct 12, 2021
@Moelf Moelf deleted the rm_polyester branch October 12, 2021 01:36
Moelf added a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threading failure with @batch
1 participant