Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression algo: LZ4 and LZMA at least for Streamers and tests #19

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Jul 1, 2021

No description provided.

@Moelf
Copy link
Member Author

Moelf commented Jul 1, 2021

Eventually we need to make an iterative approach for this anyways because data apparently cannot be dumped easily..... (idk why, but I thought LZMA should be as tolerant as LibZ but no, it doesn't like extra garbage bytes at the end even if we're not reading into them)

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #19 (c60855c) into master (0aa6c8c) will decrease coverage by 0.11%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   77.24%   77.13%   -0.12%     
==========================================
  Files           8        7       -1     
  Lines         879      892      +13     
==========================================
+ Hits          679      688       +9     
- Misses        200      204       +4     
Impacted Files Coverage Δ
src/types.jl 84.28% <50.00%> (-6.20%) ⬇️
src/streamers.jl 86.66% <100.00%> (+0.65%) ⬆️
src/io.jl 86.56% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa6c8c...c60855c. Read the comment docs.

@tamasgal
Copy link
Member

tamasgal commented Jul 1, 2021

Amazing, thanks!

@tamasgal tamasgal merged commit ec49551 into JuliaHEP:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants