-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Jagged branch from CMS NanoAOD #22
Conversation
Moelf
commented
Jul 2, 2021
•
edited
edited
- handle multiple blocks in datastream
- hard code TLeafB
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 78.09% 80.88% +2.78%
==========================================
Files 7 8 +1
Lines 904 926 +22
==========================================
+ Hits 706 749 +43
+ Misses 198 177 -21
Continue to review full report at Codecov.
|
|
@tamasgal I'm gonna squash merge this since tests and converge both seem happy. I'd propose drop 1.0 support since next LTS (1.6 or 1.7) is right around the corner. Let me know what you think |
Very nice work! I'd suggest to add Something like below right into if VERSION < v"1.2"
hasproperty(x, s::Symbol) = s in fieldnames(typeof(x))
end |
5e9146f
to
ea7a5dc
Compare