-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment.yml #400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 44 44
Lines 2746 2746
=======================================
Hits 2444 2444
Misses 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Fingers crossed this works 🤞.
I will try to generate a docker image of this PR with MyBinder. If that is not possible I will just merge to test it. |
I was able to create an image! https://mybinder.org/v2/gh/curtcorum/KomaMRI.jl/docker_jupyterlab_pluto But I could not launch the Pluto server, probably we still need to add |
Great, and not great!
There is no doubt some configuration for docker, and potentially for the jupyter-pluto-proxy file config to get spefic notebooks to spin up.
I spent a bit of time getting a local docker instance going for testing.
On June 3, 2024 10:53:39 PM CDT, Carlos Castillo Passi ***@***.***> wrote:
I was able to create an image! https://mybinder.org/v2/gh/curtcorum/KomaMRI.jl/docker_jupyterlab_pluto
But I could not launch the Pluto server, probably we still need to add `Pluto.jl` in the `Dockerfile`, like in https://github.com/yuvipanda/jupyter-pluto-proxy/blob/main/Dockerfile#L10.
--
Reply to this email directly or view it on GitHub:
#400 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Awesome!
On June 3, 2024 11:26:44 PM CDT, Carlos Castillo Passi ***@***.***> wrote:
It works! if I install `Pluto`, `PlutoUI` and `PlutoPlotly` using JupyterLab's Julia console, I can run Pluto notebooks quite fast!
![image](https://github.com/JuliaHealth/KomaMRI.jl/assets/5957134/f51bb5d2-c168-41ff-834b-be619e681fd6)
To take advantage of Binder's prebuilt environment, I disabled the reproducible aspect of the Pluto notebook with
```julia
begin
import Pkg
Pkg.activate("/home/jovyan/") # Use environment with Koma preinstalled
end
```
--
Reply to this email directly or view it on GitHub:
#400 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Update, we can launch a specific Jupyter notebook (python or julia) from a binder link, also can launch into an active Pluto start page session...still cannot go direct to a specific Pluto notebook... see: #399 (comment) |
Amazing, when this is merged, we can point to the |
Ok, the links to the binder work properly with Literate, but the docker image fails to generate (https://mybinder.org/v2/gh/JuliaHealth/KomaMRI.jl/gh-pages). I will need to take a look later this week. |
Hi! I managed to fix this in https://juliahealth.org/KomaMRI.jl/dev/
Sometimes, building the docker image times out, but that will be fixed when we tag v0.9, which removes CUDA as a strong dependency. Also, I am not completely sure how to make Pluto notebooks use the compiled environment by default yet, but at least they work and open directly! EDIT: modifying the package loading cell to begin
import Pkg
Pkg.activate("/home/jovyan/.binder/")
using KomaMRI, PlutoPlotly, PlutoUI
end seems to work. |
e591a37
to
4ad545e
Compare
#399 (comment)
Adding https://github.com/yuvipanda/jupyter-pluto-proxy so that Pluto can be used from JupyterLab in binder instances.
Pluto should only get loaded in the docker instance, if I understand correctly.