Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetDrugExposureStartDate Function #70

Closed
wants to merge 1 commit into from

Conversation

nitverse
Copy link

@nitverse nitverse commented Jan 4, 2024

Added the function getDrugExposureStartDate as mentioned in the issue #68

Added the function getDrugExposureStartDate as mentioned in the issue JuliaHealth#68
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ac5bcf0) 74.51% compared to head (54c4504) 73.33%.

Files Patch % Lines
src/getters.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   74.51%   73.33%   -1.19%     
==========================================
  Files           6        6              
  Lines         310      315       +5     
==========================================
  Hits          231      231              
- Misses         79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheCedarPrince
Copy link
Member

Hi @nitverse,

Thanks for giving this a try! There's still a fair amount of work to do on this as of now, but happy to work with you through it! Here's what else needs to be done:

  • Add an execution dispatch for this function which executes the code against the database
  • Add a dispatch which accepts a dataframe object
  • Add a reference to the function within the documentation
  • Add tests for all the dispatches

Thankfully, we've enumerated this procedure in a pretty straightforward manner and would suggest looking at the code example here:

GetVisitProcedure(visit_ids, conn; tab = procedure_occurrence)
and referring to the PR I mentioned in the original issue.

Let me know if you have any questions!

@Jay-sanjay Jay-sanjay changed the title [FEATURE] Add New Function GetDrugExposureStartDate #68 Added GetDrugExposureStartDate Function Jan 4, 2024
@TheCedarPrince
Copy link
Member

Hey @nitverse -- were you going to work more on this PR?

@Jay-sanjay
Copy link
Member

This is fixed by #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants