Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to LLVM's license, delete LLVMBuild.txt files #173

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dpaoliello
Copy link
Collaborator

  • Update header comments and LICENSE files to match LLVM ("Apache License v2.0 with LLVM Exceptions").
  • Add missing header comments.
  • Delete vestigial LLVMBuild.txt files (LLVMBuild was removed from LLVM a long time ago).

Fixes #87

@dpaoliello dpaoliello requested a review from vtjnash July 19, 2023 21:27
@vtjnash
Copy link
Member

vtjnash commented Jul 20, 2023

There may need to be some work to confirm that all contributors are okay with the change here. I am unaware of the current status of the equivalent effort for LLVM.

@hikari-no-yume
Copy link
Collaborator

The old and new licenses are compatible, so it's essentially sublicensing rather than relicensing and should be no issue (#87).

@dpaoliello
Copy link
Collaborator Author

There may need to be some work to confirm that all contributors are okay with the change here. I am unaware of the current status of the equivalent effort for LLVM.

LLVM is still in the process of relicensing their source: https://foundation.llvm.org/docs/relicensing/

The old and new licenses are compatible, so it's essentially sublicensing rather than relicensing and should be no issue (#87).

Correct - per the link above the legacy license is kept for parts that haven't been relicensed yet and "Once the codebase is fully covered by the new license, we’ll drop the old license."

@vtjnash
Copy link
Member

vtjnash commented Jul 20, 2023

I don't see how sublicensing is relevant here. Sublicensing is your right to ship this software to someone else under the terms of the original LLVM Release License. It does not give you the right to change or remove any text of the original license or to claim the copyright yourself.

@dpaoliello
Copy link
Collaborator Author

I don't see how sublicensing is relevant here. Sublicensing is your right to ship this software to someone else under the terms of the original LLVM Release License. It does not give you the right to change or remove any text of the original license or to claim the copyright yourself.

Fair point.

It is relicensing, but the inclusion of the "Legacy License" allows the old code to be licensed under that until those previous contributors can agree to relicense.

@vtjnash
Copy link
Member

vtjnash commented Jul 20, 2023

That is true. Also, the list of contributors here is much smaller though. Someone could go back through the git log from LLVM, generate a list of authors, and check that much smaller list against the master list from LLVM and determine if this is already valid to change now.

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold waiting for someone to do an authorship listing and contact the LLVM foundation for confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only the old LLVM license is used
3 participants