Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arguably better defaults for tabs and pairs #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfitzseb
Copy link

Because of JuliaIDE/Julia-LT#167
and http://discuss.junolab.org/t/german-keyboard/126/10

Maybe this should go along with some instructions to get the paired brackets to work again.

@MikeInnes
Copy link
Contributor

So this one's a bit tricky because you have to make things inconvenient for someone. LT went with what you're suggesting, to get rid of the pairing. I figure it's probably better to fix the problem, rather than hiding it.

Maybe a better stopgap would be to detect a german keyboard layout and then disable pairing?

@pfitzseb
Copy link
Author

pfitzseb commented Mar 3, 2015

Sure - if you know of a way to reliably detect the keyboard layout, that'd be a better solution (unfortunately I didn't find anything about that).
And if there's no way to automate this and we have to rely on user input, this is as good a way as any.

The best solution though would be to fix the underlying issue... Possibly relevant issue.
A possible solution would be to add an option to detect charcodes (e.g. 91 for [) instead of keycodes because that would be universal for all keyboard layouts. Then we could do something like [:editor.keys.normal "[" (:editor.open-pair "[") :charcode] and get the desired behaviour across the board.
The other behaviour is still needed so that specifying a modifier still works.

tkelman added a commit to tkelman/Juno-LT that referenced this pull request Jul 6, 2015
@tkelman tkelman mentioned this pull request Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants