Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 1.6 update seems to have broken load from URLs for CSVFiles #320

Closed
davidanthoff opened this issue Apr 4, 2021 · 0 comments · Fixed by #327
Closed

The 1.6 update seems to have broken load from URLs for CSVFiles #320

davidanthoff opened this issue Apr 4, 2021 · 0 comments · Fixed by #327

Comments

@davidanthoff
Copy link
Contributor

I think this must be another breaking change that was introduced in 1.6: CSVFiles.jl forever has supported loading of files from URLs, i.e. something like load("https://raw.githubusercontent.com/queryverse/CSVFiles.jl/v0.2.0/test/data.csv") used to work. With the new release of 1.6 of FileIO this now throws an error ArgumentError: No file exists at given path: https://raw.githubusercontent.com/queryverse/CSVFiles.jl/v0.2.0/test/data.csv, I think at this location.

That check should probably only happen if the file argument references a local path?

CC @timholy because blame says you changed this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant