Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate generic seekend method #198

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Deprecate generic seekend method #198

wants to merge 2 commits into from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 30, 2024

Ref: #183

@nhz2 nhz2 marked this pull request as draft March 30, 2024 02:32
@nhz2 nhz2 marked this pull request as ready for review March 30, 2024 02:38
@nhz2 nhz2 requested review from jakobnissen and mkitti March 30, 2024 18:01
@mkitti
Copy link
Member

mkitti commented Mar 30, 2024

Use @deprecate.

help?> @deprecate
  @deprecate old new [export_old=true]

  Deprecate method old and specify the
  replacement call new, defining a new method
  old with the specified signature in the
  process.

  To prevent old from being exported, set
  export_old to false.

@nhz2
Copy link
Member Author

nhz2 commented Mar 30, 2024

I'm not sure what new should be in this case.

@nhz2
Copy link
Member Author

nhz2 commented Mar 30, 2024

Maybe it would be better not to deprecate and just remove the method in 0.11

I think the main reason for removing seekend is it enables things like:
Try to seekend and if that works use a seeking strategy, otherwise, use a streaming strategy.

Also related JuliaLang/julia#24242

@mkitti
Copy link
Member

mkitti commented Mar 30, 2024

Well it would nice to make this compatible with --depwarn=true which should default to false for normal users.

@nhz2 nhz2 marked this pull request as draft March 30, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants