Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for GPUCompiler to 0.23-0.26 #43

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 14, 2024

This pull request changes the compat entry for the GPUCompiler package from 0.21.4 to 0.21.4, 0.26.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.


From #27 (comment):

Memo to self: replace

code = quote
$GPUCompiler.@override($method_table, $ex)
end
if isdefined(Base.Experimental, Symbol("@overlay"))
return esc(code)
else
push!(overrides, code)
return
end
with

    return esc(:( Base.Experimental.@overlay($method_table, $ex) ))

and require julia v1.8.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-03-14-20-55-19-872-01821700940 branch from c9689cc to 952f65a Compare March 14, 2024 20:55
@giordano giordano marked this pull request as draft March 14, 2024 23:16
@giordano giordano force-pushed the compathelper/new_version/2024-03-14-20-55-19-872-01821700940 branch 3 times, most recently from 146bbeb to db3d378 Compare April 5, 2024 15:01
@giordano giordano marked this pull request as ready for review April 8, 2024 13:12
@giordano giordano force-pushed the compathelper/new_version/2024-03-14-20-55-19-872-01821700940 branch from 7551807 to 1e2efe8 Compare April 8, 2024 13:12
@giordano giordano changed the title CompatHelper: bump compat for GPUCompiler to 0.26, (keep existing compat) CompatHelper: bump compat for GPUCompiler to 0.23-0.26 Apr 8, 2024
@giordano
Copy link
Collaborator

giordano commented Apr 8, 2024

I verified locally that tests pass with hardware IPU with all minor versions of GPUCompiler 0.23-0.26, so this is ready to be merged.

@giordano giordano merged commit 438bd84 into main Apr 8, 2024
2 checks passed
@giordano giordano deleted the compathelper/new_version/2024-03-14-20-55-19-872-01821700940 branch April 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant