rework dispatches and update compatibility #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much clearer to dispatch on pixel type, rather than the array type. So intead of extend `evaluate`, we extend `eval_op` now.
there're two other patches: * provide limited support to non-boolean image when it can be binarized without InExactError * fix pariwise for GenericHausdorff; the previous function can't get called due to an incorrect type annotation
juliohm
reviewed
Aug 9, 2019
juliohm
reviewed
Aug 9, 2019
|
Unfortunately, ambiguities still exist (moves from |
johnnychen94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 69.1% 87.61% +18.5%
==========================================
Files 6 6
Lines 123 113 -10
==========================================
+ Hits 85 99 +14
+ Misses 38 14 -24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this rewrite is to close #22, close #28 and close #25 . Also, it's much easier to understand and maintain the source codes.
This rework consists of three updates:
result_typeon::Typerather than::AbstractArray(blocked by rework result_type JuliaStats/Distances.jl#140)eval_opinstead ofevaluate. The latter introduces a lot of method ambiguities (e.g., avoid type piracy? #28 (comment) reported by @tlnagy)ImageCore >= 0.8.3--> I'd like to make this a seperate PR but it's required to simplify the dispatching.Todo:
cc: @juliohm