Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples for document #62

Merged
merged 4 commits into from
May 29, 2021
Merged

Conversation

hyrodium
Copy link
Contributor

This PR includes the following updates:

  • Fix misleading words
  • Update the title of the document
  • Fix @example blocks in the document
  • Fix docstring for drawifinbounds!

@hyrodium
Copy link
Contributor Author

On current master branch, we have a jaggy image and invalid # hide script.

image

With this PR, these problems are solved.
image

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for these improvements!

@@ -340,6 +340,7 @@ Draws a single point after checkbounds() for coordinate in the image.
Color Defaults to oneunit(T)

"""
drawifinbounds!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nice catch 👍

@johnnychen94 johnnychen94 merged commit 8ad55d9 into JuliaImages:master May 29, 2021
@hyrodium
Copy link
Contributor Author

On current master branch, the docs generation is failing.

image

https://github.com/JuliaImages/ImageDraw.jl/runs/2701413156

I've added a dependency on Images.jl in #64, so this problem will be fixed when the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants