Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip prefilter step for BSpline(Linear()) and BSpline(Constant()) #123

Closed
johnnychen94 opened this issue May 20, 2021 · 1 comment
Closed

Comments

@johnnychen94
Copy link
Member

This difference is originally identified by @andrew-saydjari in #116 (comment) and I believe we could optimize it away:

img = testimage("cameraman")

imrotate(img, 0.3; method=Linear()) == imrotate(img, 0.3; method=BSpline(Linear())) # true

@btime imrotate($img, 0.3; method=Linear()); # 3.479 ms (21 allocations: 403.88 KiB)
@btime imrotate($img, 0.3; method=BSpline(Linear())); # 3.491 ms (23 allocations: 660.02 KiB)
@johnnychen94
Copy link
Member Author

closed by #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant