Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip prefilter for Linear and Constant #125

Merged
merged 2 commits into from May 20, 2021
Merged

skip prefilter for Linear and Constant #125

merged 2 commits into from May 20, 2021

Conversation

johnnychen94
Copy link
Member

Now that Linear() is just equivalent to BSpline(Linear()):

using ImageTransformations, ImageCore, ImageShow, TestImages, Interpolations
img = testimage("cameraman");

@btime imrotate($img, 0.3; method=Linear()); # 3.557 ms (21 allocations: 403.88 KiB)
@btime imrotate($img, 0.3; method=BSpline(Linear()));
# master: 3.491 ms (23 allocations: 660.02 KiB)
# PR: 3.639 ms (21 allocations: 403.88 KiB)

cc: @andrew-saydjari

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #125 (a733467) into master (eb94fc2) will decrease coverage by 0.23%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   94.09%   93.86%   -0.24%     
==========================================
  Files           8        8              
  Lines         322      326       +4     
==========================================
+ Hits          303      306       +3     
- Misses         19       20       +1     
Impacted Files Coverage Δ
src/compat.jl 77.77% <66.66%> (-5.56%) ⬇️
src/interpolations.jl 72.00% <100.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb94fc2...a733467. Read the comment docs.

@johnnychen94 johnnychen94 mentioned this pull request May 20, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant