Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all summary test #136

Merged
merged 3 commits into from Jul 13, 2021
Merged

remove all summary test #136

merged 3 commits into from Jul 13, 2021

Conversation

johnnychen94
Copy link
Member

summary results are not very stable; it differs from version to version. Hence I replace all summary tests with axes, eltype and size tests.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #136 (0239d47) into master (d883892) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files           8        8           
  Lines         215      215           
=======================================
  Hits          198      198           
  Misses         17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d883892...0239d47. Read the comment docs.

@Evizero
Copy link
Member

Evizero commented Jul 13, 2021

I agree wit your point. the one thing I would argue is that it would be nice to at least test that the summary code can be executed without an error

@johnnychen94
Copy link
Member Author

I've added the summary back with @test_nowarn summary(...). But actually, since ImageTransformations doesn't override summary method for any of the view types, the summary(...) should just work.

@johnnychen94 johnnychen94 merged commit 226d504 into master Jul 13, 2021
@johnnychen94 johnnychen94 deleted the jc/summary_test branch July 13, 2021 09:51
@johnnychen94 johnnychen94 mentioned this pull request Jul 13, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants