Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an overall module docstring #152

Merged

Conversation

zelunw
Copy link
Contributor

@zelunw zelunw commented Nov 2, 2021

?ImageTransformations

Created using ModuleDocstrings.jl
with introduction and docstring for restrict copied from https://juliaimages.org/ImageTransformations.jl/dev/
and examples from
https://juliaimages.org/latest/pkgs/transformations/

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #152 (d45c1e8) into master (85ec60f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files           8        8           
  Lines         216      216           
=======================================
  Hits          195      195           
  Misses         21       21           
Impacted Files Coverage Δ
src/ImageTransformations.jl 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ec60f...d45c1e8. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! With a couple of tweaks I think this is mergeable.

src/ImageTransformations.jl Show resolved Hide resolved
src/ImageTransformations.jl Outdated Show resolved Hide resolved
src/ImageTransformations.jl Outdated Show resolved Hide resolved
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and a question. Others look good to me. Thanks for the proposal.

src/ImageTransformations.jl Outdated Show resolved Hide resolved
src/ImageTransformations.jl Outdated Show resolved Hide resolved
Add `` around `imresize!`

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
src/ImageTransformations.jl Outdated Show resolved Hide resolved
src/ImageTransformations.jl Outdated Show resolved Hide resolved
@johnnychen94 johnnychen94 merged commit 4ce509c into JuliaImages:master Nov 5, 2021
@timholy
Copy link
Member

timholy commented Nov 5, 2021

Thanks, @zelunw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants