Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compat] ImageCore 0.10 #164

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[compat] ImageCore 0.10 #164

merged 3 commits into from
Jul 20, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 20, 2023

Also drops the direct dependence on ColorVectorSpace,
since that's loaded by ImageCore (in recent versions).

There appear to be subtle changes in brightness in the images (an I/O issue??), hence the change in test result. But I've checked visually and they aren't geometric issues that I can see.

Also drops the direct dependence on ColorVectorSpace,
since that's loaded by ImageCore (in recent versions).
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (7557c6c) 89.81% compared to head (da8db07) 90.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   89.81%   90.04%   +0.23%     
==========================================
  Files           8        8              
  Lines         216      221       +5     
==========================================
+ Hits          194      199       +5     
  Misses         22       22              
Impacted Files Coverage Δ
src/ImageTransformations.jl 85.71% <ø> (+2.38%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit 570ea3f into master Jul 20, 2023
8 checks passed
@timholy timholy deleted the teh/compat_ic0.10 branch July 20, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant