Add flag to control outputting of system code #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnimuc
reviewed
Apr 17, 2024
src/generator/passes.jl
Outdated
|
|
||
| show_info && @info "[GeneralPrinter]: print to $(x.file)" | ||
| open(x.file, "a") do io | ||
| for node in dag.nodes | ||
| !output_system && string(node.id) in map(it -> string(it.id), dag.sys) && continue |
There was a problem hiding this comment.
We should add the same change to StdPrinter etc.
|
I changed the option name to |
Octogonapus
commented
Apr 17, 2024
src/generator/passes.jl
Outdated
| @@ -943,6 +943,7 @@ function (x::FunctionPrinter)(dag::ExprDAG, options::Dict) | |||
| show_info = get(log_options, "FunctionPrinter_log", x.show_info) | |||
| ignorelist = get(general_options, "output_ignorelist", get(general_options, "printer_blacklist", [])) | |||
| exclusivelist = get(general_options, "output_exclusivelist", nothing) | |||
| get(general_options, "generate_isystem_symbols", true) && append!(ignorelist, string(x.id) for x in dag.sys) | |||
There was a problem hiding this comment.
I believe this logic is inverted
|
After fixing the logic and trying it out, this new implementation is very slow because the ignorelist is quite large and running all of those regular expressions is slow. I would recommend to use the prior implementation because it is much faster. |
|
@Octogonapus fixed again. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
output_system(trueby default for backwards compatibility) which controls whether code in system headers will be output.Setting this flag to false allows the user to effectively avoid emitting code for dependencies by including those dependencies as system headers.
I have tested this with my MWE in #484 and it solves that issue.
Fixes #484.