Remove overloading promote_type
#426
Conversation
|
This change results in the error: If I remember correctly that is also the reason I opted to override |
|
That error pops up because there is no It seems to me the correct solution for that would be to provide suitable binary ops for those types, which then also could preserve the types. So this is the library code raising the error: for op in (:+, :-, :*, :&, :|, :xor)
@eval function $op(a::Integer, b::Integer)
T = promote_typeof(a, b)
aT, bT = a % T, b % T
not_sametype((a, b), (aT, bT))
return $op(aT, bT)
end
endyou could adapt it to something like this: for op in (:+, :-, :*, :&, :|, :xor)
@eval function Base.$op(a::S, b::S) where {S<:CxxNumber}
T = julia_int_type(S)
aT, bT = a % T, b % T
Base.not_sametype((a, b), (aT, bT))
return S($op(aT, bT))
end
end |
Co-authored-by: Max Horn <max@quendi.de>
to keep this change non-breaking
|
Thanks @fingolfin for the help! Unfortunately that does not work directly as it coerces the results of arithmetic operations back to the Cxx type, but it is explicitly tested in CxxWrap.jl/test/basic_types.jl Line 166 in 63daec0 But just removing the last coercion seems to work. |
|
Thanks, well spotted! |
Resolves #425 in the way that is outlined in the docstrings