Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @intervalbox macro #33

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Remove @intervalbox macro #33

merged 1 commit into from
Jun 1, 2017

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented May 19, 2017

I think we should include this in 0.9.1, @lbenet.

@coveralls
Copy link

coveralls commented May 20, 2017

Coverage Status

Coverage increased (+0.1%) to 92.5% when pulling a611629 on remove_intervalbox_macro into 64f72c7 on master.

@codecov-io
Copy link

codecov-io commented May 20, 2017

Codecov Report

Merging #33 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #33     +/-   ##
========================================
+ Coverage   92.39%   92.5%   +0.1%     
========================================
  Files          22      21      -1     
  Lines         921     920      -1     
========================================
  Hits          851     851             
+ Misses         70      69      -1
Impacted Files Coverage Δ
src/IntervalArithmetic.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f72c7...a611629. Read the comment docs.

@lbenet
Copy link
Member

lbenet commented Jun 1, 2017

This could be merged right away, but I think we should merge first JuliaIntervals/IntervalRootFinding.jl#8, which requires some tests and docstrings, and then this one.

@dpsanders
Copy link
Member Author

I'm actually not sure that the @intervalbox macro is that useful / necessary if all the other functions are written in the correct way.

@lbenet
Copy link
Member

lbenet commented Jun 1, 2017

Then, I'll merge this, and we keep the discussion about having or not @intervalbox in JuliaIntervals/IntervalRootFinding.jl#8

@lbenet
Copy link
Member

lbenet commented Jun 1, 2017

Thanks, by the way!

@lbenet lbenet merged commit b5ce9ae into master Jun 1, 2017
@dpsanders
Copy link
Member Author

OK, great, thanks!

@dpsanders dpsanders deleted the remove_intervalbox_macro branch August 2, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants