Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes libieeep1788_tests_overlap.jl #403

Closed
wants to merge 4 commits into from
Closed

Completes libieeep1788_tests_overlap.jl #403

wants to merge 4 commits into from

Conversation

krish8484
Copy link
Collaborator

This PR aims to satisfy tests of the file libieeep1788_tests_overlap.jl, and thereby completing #266.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.236% when pulling 1d88133 on krish8484:overlap_function into d3a318c on JuliaIntervals:master.

@dpsanders
Copy link
Member

I thought overlap was already implemented before?

I think we would want it to return Symbols, rather than Strings.

@lucaferranti
Copy link
Member

superseeded by #518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krish8484 @coveralls @dpsanders @lucaferranti @yashrajgupta