Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch for exponentiation on Float32 intervals #482

Merged
merged 4 commits into from
May 7, 2022

Conversation

mfherbst
Copy link
Contributor

@mfherbst mfherbst commented Jul 18, 2021

Currently this fails:

Interval(1.0f0) ^ Interval(1.0f0)

while this works

Interval(1.0) ^ Interval(1.0)

With this change both things will work, but I'm not too sure if it's the right thing to do.

Happy to add tests etc.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #482 (887e438) into master (a3dc27f) will decrease coverage by 1.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   91.55%   90.35%   -1.20%     
==========================================
  Files          25       25              
  Lines        1752     1794      +42     
==========================================
+ Hits         1604     1621      +17     
- Misses        148      173      +25     
Impacted Files Coverage Δ
src/intervals/functions.jl 96.08% <100.00%> (+4.66%) ⬆️
src/intervals/rounding_macros.jl 0.00% <0.00%> (-100.00%) ⬇️
src/decorations/functions.jl 83.81% <0.00%> (-11.51%) ⬇️
src/decorations/intervals.jl 74.46% <0.00%> (-10.32%) ⬇️
src/intervals/macros.jl 100.00% <0.00%> (ø)
src/multidim/setdiff.jl 100.00% <0.00%> (ø)
src/intervals/hyperbolic.jl 100.00% <0.00%> (ø)
src/plot_recipes/plot_recipes.jl 0.00% <0.00%> (ø)
src/intervals/trigonometric.jl 97.68% <0.00%> (+0.01%) ⬆️
src/intervals/precision.jl 96.77% <0.00%> (+0.10%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dc27f...887e438. Read the comment docs.

@lbenet
Copy link
Member

lbenet commented Oct 29, 2021

Thanks @mfherbst and sorry for the long delay to get into this. It would be nice to have some tests. Aside from that, LGTM!

@lbenet
Copy link
Member

lbenet commented Apr 22, 2022

Incidentally, I noticed that this works in the 1.0-branch

@lucaferranti lucaferranti merged commit 06f49c2 into JuliaIntervals:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants