Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intervalbox.jl #520

Merged
merged 3 commits into from
May 19, 2022
Merged

Update intervalbox.jl #520

merged 3 commits into from
May 19, 2022

Conversation

mforets
Copy link
Contributor

@mforets mforets commented May 15, 2022

Fixes #519


A few tests could be added here, eg.

x = 0.5 .. 3
a = IntervalBox(A[1]) # 1 .. 2
@test !(x  a) && a  x
@test !(x  a) && a  x
@test x  a == a  x == A[1]
@test x  a ==  a  x == x

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2022

Codecov Report

Merging #520 (aaad6db) into master (06f49c2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   90.35%   90.36%   +0.01%     
==========================================
  Files          25       25              
  Lines        1794     1796       +2     
==========================================
+ Hits         1621     1623       +2     
  Misses        173      173              
Impacted Files Coverage Δ
src/multidim/intervalbox.jl 89.83% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f49c2...aaad6db. Read the comment docs.

@lucaferranti
Copy link
Member

Could you add those tests and bump the patch version?

In principle, if we accept those we should also support all other operations (arithmetic etc.) but it can be left for future PRs if/when someone needs those.

@lucaferranti lucaferranti merged commit f8a5b5e into JuliaIntervals:master May 19, 2022
@lucaferranti
Copy link
Member

@lbenet should we cherrypick this to 1.0-dev?

lucaferranti pushed a commit that referenced this pull request May 27, 2022
* Update intervalbox.jl

* Update multidim.jl

* Update Project.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend inclusion check for interval and interval box
3 participants