Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parser #522

Merged
merged 7 commits into from May 25, 2022
Merged

fix parser #522

merged 7 commits into from May 25, 2022

Conversation

lucaferranti
Copy link
Member

No description provided.

@lucaferranti lucaferranti requested a review from lbenet May 21, 2022 18:47
@lucaferranti
Copy link
Member Author

lucaferranti commented May 21, 2022

@lbenet this fixes almost all errors in the ITF1788 files (except for reverse functions). The remaining ones are not related to parsing but to the DecoratedInterval constructor and hence it might be better to address that in a separate PR (decorated intervals constructor are my immediate next step on my todo list).

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.0-dev@f385b7f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             1.0-dev     #522   +/-   ##
==========================================
  Coverage           ?   84.50%           
==========================================
  Files              ?       34           
  Lines              ?     1775           
  Branches           ?        0           
==========================================
  Hits               ?     1500           
  Misses             ?      275           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f385b7f...b4f1120. Read the comment docs.

@lucaferranti
Copy link
Member Author

ah also to note that atm the tests are not checking that warnings are thrown when they should. I would like to address warnings checks in a separate PR (after the constructors are fixed)

@lucaferranti
Copy link
Member Author

last but not least, if you are wondering where the green checks come from, that's because I temporarily disabled the tests for reverse functions... we know they are failing and there's an issue in IntervalContractors.jl, so better to leave those out for the time being.

@lucaferranti lucaferranti mentioned this pull request May 21, 2022
16 tasks
@lucaferranti
Copy link
Member Author

lucaferranti commented May 21, 2022

@lbenet now ALL tests related to strings / parsing pass 🎉

FYI the only failing ITF tests (except for reverse functions)

  • 8 related to constructing decorated intervals, easy to fix, PR on the way already 💪 🚀
  • one related to the accurate dot product

Copy link
Collaborator

@Kolaru Kolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great that the tests now pass =)

My comments are only about exception handling and documentation, all the rest looks good to me.

src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
lucaferranti and others added 2 commits May 23, 2022 15:16
Co-authored-by: Benoît Richard <kolaru@hotmail.com>
@lucaferranti lucaferranti requested a review from Kolaru May 23, 2022 13:13
Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucaferranti for addressing this! In general, LGTM, and I'm in favor of merging this.

I left few comments that are optional. Perhaps the only relevant is related to the tests, which instead of being removed could be adapted to test other numeric formats (Float32, etc).

src/parsing.jl Show resolved Hide resolved
test/interval_tests/parsing.jl Show resolved Hide resolved
test/test_ITF1788/run_ITF1788.jl Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Show resolved Hide resolved
@lucaferranti
Copy link
Member Author

@lbenet now added some tests for float32 and bigfloat

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@lbenet lbenet merged commit 1b84a19 into 1.0-dev May 25, 2022
@lbenet
Copy link
Member

lbenet commented May 25, 2022

Merged!

It's really nice to see again green colors in the tests!

@lbenet lbenet deleted the lf-parser branch May 25, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants