New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isatomic function and tests #58

Merged

dpsanders merged 3 commits into master from isatomic

Jun 12, 2017

Member

dpsanders commented Jun 11, 2017 •

edited

Loading

Closes #46

dpsanders added 2 commits

June 11, 2017 11:33


          Add isatomic function and tests

034ac8c


          Add docstring for isatomic

f4ce358

dpsanders mentioned this pull request

Add isatomic function #46

Closed

codecov-io commented Jun 11, 2017 •

edited

Loading

Codecov Report

Merging #58 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +<.01%     
==========================================
  Files          21       21              
  Lines         966      967       +1     
==========================================
+ Hits          885      886       +1     
  Misses         81       81

Impacted Files	Coverage Δ
src/IntervalArithmetic.jl	`100% <ø> (ø)`	⬆️
src/intervals/special.jl	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b91d8...1f8d642. Read the comment docs.

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

3 similar comments

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

2 similar comments

coveralls commented Jun 11, 2017

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

coveralls commented Jun 11, 2017 •

edited

Loading

Coverage increased (+0.009%) to 91.624% when pulling f4ce358 on isatomic into 73b91d8 on master.

lbenet approved these changes

View reviewed changes

Member

lbenet left a comment

Thanks a lot!

I have one minor correction (docstrings) and a
a simple suggestion. Merge at will!

src/intervals/special.jl Outdated

+              """
+                  isatomic(x::Interval)
+              Check is an interval `x` is an *atomic* interval, i.e. is unable to be split.

Member

lbenet Jun 12, 2017

A correction and an addition: "Check if ... to be split in finite precision.`

test/interval_tests/consistency.jl Outdated

+                      @test isatomic(Interval(1))
+                      @test isatomic(Interval(2.3, 2.3))
+                      @test isatomic(emptyinterval())
+                      @test isatomic(Interval(realmax(), ∞))

Member

lbenet Jun 12, 2017

This can be written as: @test isatomic(@interval(Inf)).


          Fixes after review

1f8d642

Member Author

dpsanders commented Jun 12, 2017

Fixed, thanks!

coveralls commented Jun 12, 2017 •

edited

Loading

Coverage increased (+0.009%) to 91.624% when pulling 1f8d642 on isatomic into 73b91d8 on master.

dpsanders merged commit 1bf5896 into master

dpsanders deleted the isatomic branch

August 2, 2017 19:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment