Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated oettli-präger #41

Merged
merged 4 commits into from Jul 7, 2021
Merged

updated oettli-präger #41

merged 4 commits into from Jul 7, 2021

Conversation

lucaferranti
Copy link
Member

@lucaferranti lucaferranti commented Jul 1, 2021

  • now users does not need to give list of variables explictly
  • initial enclosure is an optional parameter and is automatically computed if not given
  • as these functionalities are optional and require ICP.jl to be imported first, Documenter does not include their docstrings in the API docs At the moment, I don't know how to fix this.
  • make OettliPrager <: LinearSolver so that it can be used within solve like other solvers.

@lucaferranti lucaferranti marked this pull request as draft July 1, 2021 20:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #41 (34eb84e) into main (ac310e0) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   95.92%   96.03%   +0.10%     
==========================================
  Files           8        8              
  Lines         221      227       +6     
==========================================
+ Hits          212      218       +6     
  Misses          9        9              
Impacted Files Coverage Δ
src/IntervalLinearAlgebra.jl 100.00% <ø> (ø)
src/solvers/oettli.jl 100.00% <100.00%> (ø)
src/solvers/solve.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac310e0...34eb84e. Read the comment docs.

@lucaferranti lucaferranti linked an issue Jul 1, 2021 that may be closed by this pull request
@lucaferranti lucaferranti mentioned this pull request Jul 2, 2021
12 tasks
@lucaferranti lucaferranti marked this pull request as ready for review July 4, 2021 08:41
@lucaferranti lucaferranti merged commit e0a4d2c into main Jul 7, 2021
@lucaferranti lucaferranti deleted the lf/oettli branch July 7, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oettli-präger solver should not need a list of variables as input
3 participants