Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39 - Pass kwargs to minimise #40

Merged
merged 1 commit into from Jul 19, 2019

Conversation

mforets
Copy link
Contributor

@mforets mforets commented Jul 10, 2019

Closes #39.

@dpsanders dpsanders mentioned this pull request Jul 10, 2019
@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #40 into master will increase coverage by 3.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   85.93%   89.06%   +3.12%     
==========================================
  Files           4        4              
  Lines          64       64              
==========================================
+ Hits           55       57       +2     
+ Misses          9        7       -2
Impacted Files Coverage Δ
src/optimise.jl 94.44% <100%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28247f...46c478e. Read the comment docs.

@mforets
Copy link
Contributor Author

mforets commented Jul 10, 2019

@dpsanders Should i add a test?

@dpsanders
Copy link
Member

Always! ;)

@mforets
Copy link
Contributor Author

mforets commented Jul 10, 2019

Ready for review.

@dpsanders dpsanders merged commit 32027e9 into JuliaIntervals:master Jul 19, 2019
@dpsanders
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodError in maximise
3 participants