Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supported for gamma function. #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

newptcai
Copy link

Changes

  • added a Project.toml
  • updated the code to work with latest packages
  • added code to call ArbNumercs.jl

Note that there is some problem with erfinv and erfcinv. Some old test cases can not finish in reasonable time. I have commented them out.

@dpsanders
Copy link
Member

Sorry for the delay in seeing this and thanks for the contribution!

Do you have any idea what the problem is?

@dpsanders
Copy link
Member

It looks like the failures are on Julia 0.6 (!) which we no longer should support.

Would you mind adding a Project.toml and testing on Julia 1.4?

@newptcai
Copy link
Author

Sorry I am getting a bit busy. Maybe this can wait a while?

@dpsanders
Copy link
Member

Yes of course, no rush - thanks!

@newptcai
Copy link
Author

The problem with erfinv is that in

function _erfinv(a::T) where T
    domain = Interval{T}(-1, 1)
    a ∉ domain && return DomainError("$a is not in [-1, 1]")
    f = x -> erf(x) - a
    fp = x->2/sqrt(pi_interval(T)) * exp(-x^2)
    rts = roots(f, fp, Interval{T}(-Inf, Inf), Krawczyk, 1e-20)
    @assert length(rts) == 1 # && rts[1].status == :unique

    rts[1].interval
end

The call to roots get stuck and never returns. That's why I commented out tests for erfinv and erfinvc.

@dpsanders
Copy link
Member

What's the status here?

@dpsanders
Copy link
Member

dpsanders commented Sep 27, 2020

Cross-reference to the original issue in IntervalArithmetic.jl:

JuliaIntervals/IntervalArithmetic.jl#372

@AnderGray
Copy link

@newptcai @dpsanders Any updates? Would be a useful thing to have :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants