Avoiding rebuilding the PDE operator in sensitivity computations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s required some breaking changes 1) added new field for PDE operator to DivSigGradParam 2) created constructor for DivSigGradParam 3) updated tests
|
As I understand it, these changes match with how we've been planning to proceed with other forward problems. I like the way the matrix storage and reuse has been implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some breaking changes
@erantreister, @dwfmarchant, @eldadHaber , @cschwarzbach, @Pbellive: Please take a look before we can merge this and update the examples in jInv. I'd like this to be somewhat consistent with the changes you made to codes for other PDEs